Keep overlay panels above reopened dialogs - #117
Merged
Conversation
…'s value The hook overwrote the overlay panel's inline z-index with a hard-coded constant. That value can sit below the current modal tier, and PrimeReact's ZIndexUtils.clear() un-registers an overlay by reading its inline z-index back — overwriting it made that lookup miss, leaked the registry entry, and every dialog opened afterwards escalated its mask's z-index further above the panels until dropdowns rendered behind the dialogs hosting them, from the second dialog open onward. The hook now only raises a panel sitting below the floor and leaves anything PrimeReact stacked at or above it untouched, with the decision extracted pure and spec'd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Overlay panels remain usable when dialogs are reopened.
Fixed